fix(ci): skip windows signing without secrets#3186
Merged
Conversation
lidel
force-pushed
the
fix/ci-skip-signing-without-secrets
branch
from
July 16, 2026 23:45
cdbe24e to
13ac46a
Compare
The fork guard never fired for Dependabot PRs, so Windows builds tried to sign with empty Azure credentials and hung until the 40 minute job timeout. Gate on whether the credential is present instead of matching on trigger type, which covers forks, Dependabot, and any future secret-less trigger on one path. Dependabot pushes its branches into the repo, so head.repo.fork is false, yet its runs only get the Dependabot secrets store and secrets.AZURE_* expand to empty strings. electron-builder 26.15.2 dropped the preflight that used to fail fast on this (electron-userland/electron-builder#9687), so Invoke-TrustedSigning falls through DefaultAzureCredential to an interactive browser login the runner can never answer. The probe step exists because steps[*].if cannot read the secrets context. Scoping the secret to that step keeps it out of every other step in the job.
lidel
force-pushed
the
fix/ci-skip-signing-without-secrets
branch
from
July 17, 2026 02:54
13ac46a to
bae2e61
Compare
lidel
marked this pull request as ready for review
July 17, 2026 10:01
Member
Author
|
Will test in #3177 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
Since 10 June, every Dependabot PR's Windows build hangs for 40 minutes and then gets cancelled.
The build tries to sign the .exe, but Dependabot PRs cannot read our signing secrets. The credentials arrive empty, so the Azure signing tool opens a browser and waits for someone to log in. Nobody can log in on a CI runner. It used to fail fast instead, until electron-builder 26.15.2 dropped the check that caught this (electron-userland/electron-builder#9687).
We already skip signing when secrets are missing, but that step only looks for forks, and Dependabot branches live in this repo.
Fix
Signing on main is unchanged, and macOS already handled this on its own. These PR binaries are unsigned: fine for testing, not for shipping.