feat: Reprovider.Strategy: rename "flat" to "all".#10928
Merged
Conversation
Value "flat" now parses to "all". Behaviour from "all" removed. Fixes #10864 which has detailed explanation.
Contributor
Author
|
@lidel I put this in the 0.37 changelog, assuming it can still get into that release. |
lidel
changed the title
guillaumemichel
approved these changes
Aug 21, 2025
guillaumemichel
left a comment
guillaumemichel
left a comment
Member
There was a problem hiding this comment.
LGTM!
Linter seems unhappy about an unused function.
It was used in the "all" strategy.
Member
|
Writing down rationale why we added this and now removing it:
|
- highlight memory efficiency improvements - clarify this removes v0.28 workaround - update config.md memory requirements - fix announce-on profile typo
- add deprecation warning in daemon.go when flat strategy is detected - document that flat is deprecated in ParseReproviderStrategy comment - add explicit test case for flat -> all mapping - flat continues to work but users are warned to migrate to all
lidel
approved these changes
Aug 21, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Value "flat" now parses to "all". Behaviour from "all" removed.
Fixes #10864 which has detailed explanation.