fix: harness tests random panic#10933
Merged
Merged
Conversation
Connecting nodes in parallel can cause TLS handshake failures. For each node, connect to the other nodes serially. It is not necessary to connect in parallel as it does not save any significant time. Closes #10932
gammazero
added
the
skip/changelog
gammazero
changed the title
Contributor
Author
|
@guillaumemichel Please try this on your system to confirm fix. |
guillaumemichel
approved these changes
Aug 22, 2025
guillaumemichel
left a comment
guillaumemichel
left a comment
Member
There was a problem hiding this comment.
Works perfectly, thanks a lot @gammazero!
Co-authored-by: Guillaume Michel <guillaumemichel@users.noreply.github.com>
lidel
added a commit
that referenced
this pull request
Aug 23, 2025
use serial Connect() implementation from PR #10933 to avoid TLS handshake issues
lidel
added a commit
that referenced
this pull request
Aug 23, 2025
use serial Connect() implementation from PR #10933 to avoid TLS handshake issues
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Connecting nodes in parallel can cause TLS handshake failures. For each node, connect to the other nodes serially. It is not necessary to connect in parallel as it does not save any significant time.
Closes #10932