feat(unixfs): use cidv1 by default#8886
Closed
schomatis wants to merge 1 commit into
Closed
Conversation
1 task
3 tasks
Member
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Toward #4143. Consumes dependency upgrade ipfs/go-unixfs#119.
@lidel Take a look at this change to see if it satisfies the CIDv1 upgrade for
ipfs filesandipfs init. There's nothing in this PR but the upgrade in UnixFS. I think the ultimate solution is landing ipfs/go-merkledag#86, but this makes a small modification in the middle layer of UnixFS to set a CIDv1 by default without much propagating big changes.I'm punting on fixing sharness until I have the modifications for the rest of the commands as I'll likely need to write a small script to parse CIDv0 and upgrade to CIDv1 all over those files. This is just a request for a manual test here and a code review in the dependency upgrade to see if I'm going in the right direction.