Skip to content

Comments

Simplify this module with binwrap#24

Closed
daviddias wants to merge 2 commits intomasterfrom
simpler
Closed

Simplify this module with binwrap#24
daviddias wants to merge 2 commits intomasterfrom
simpler

Conversation

@daviddias
Copy link
Member

This PR is an attempt at simplifying this module drastically. It uses binwrap, a npm module that pretty much does all the dark magic that this npm-go-ipfs and https://github.com/ipfs/npm-go-ipfs-dep were doing.

My goal is to move from having two modules npm-go-ipfs and npm-go-ipfs-dep to only have one.

To complete this PR:

Post merge and release

@achingbrain
Copy link
Member

The tests and the automation is in place but it'd still be great to delete half the code from this module by making this change.

@lidel
Copy link
Member

lidel commented May 4, 2021

Closing as stale: this most likely needs to be rebased/rewritten to account for hash verification and cache included in #32

@lidel lidel closed this May 4, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants