Conversation
Member
|
The tests and the automation is in place but it'd still be great to delete half the code from this module by making this change. |
Member
|
Closing as stale: this most likely needs to be rebased/rewritten to account for hash verification and cache included in #32 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR is an attempt at simplifying this module drastically. It uses
binwrap, a npm module that pretty much does all the dark magic that this npm-go-ipfs and https://github.com/ipfs/npm-go-ipfs-dep were doing.My goal is to move from having two modules
npm-go-ipfsandnpm-go-ipfs-depto only have one.To complete this PR:
Post merge and release