feat: Author-level access to evaluation metrics (Freshdesk #308)#113
Merged
Conversation
Add two-tier permission system allowing authors linked to user accounts to view their own evaluation metrics. Full access for admins/staff, read-only own-data access for linked authors. Includes BppUser.autor OneToOneField, auto-matching by email, profile page, and UI adjustments. Also fix DJ001 warnings: replace null=True with default="" on BppUser CharField fields (multiseek_format, multiseek_order_1, pbn_token).
Member
Author
|
@claude rebase |
|
Claude finished @mpasternak's task in 22s —— View job I'm unable to perform a To rebase this branch onto git fetch origin
git checkout fix/freshdesk-308
git rebase origin/dev
# resolve any conflicts if needed
git push --force-with-lease origin fix/freshdesk-308You can find more information and potential workarounds in the FAQ. |
Resolutions: - src/bpp/models/profile.py: keep branch's `default=""` (branch has backing migration to convert NULL→'' and AlterField, unlike dev's noqa-only approach) - migrations: rename 0411_bppuser_autor_onetoone → 0413 to avoid collision with dev's 0411_uczelnia_orcid_fields and 0412_uczelnia_orcid_staff_only; update dependencies accordingly
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
BppUser.autorOneToOneField linking user accounts toAutorrecords, with automatic matching by emailnull=Truewithdefault=""on BppUser CharField fieldsChanges
BppUser.autorOneToOneField +sprobuj_dopasowac_autora()auto-matching0411_bppuser_autor_onetoone(adds field + converts NULLs to empty strings)ma_pelne_uprawnienia_ewaluacji()/ma_uprawnienia_ewaluacji()inviews/mixins.pyTest plan
uv run python src/manage.py migrateto apply migration 0411uv run python src/manage.py dopasuj_autorow_do_uzytkownikowto bulk-match users to authorsuv run pytest src/ewaluacja_metryki/to verify existing tests pass🤖 Generated with Claude Code