Conversation
There was a problem hiding this comment.
Pull request overview
This PR addresses the startup failure of the web adapter integration by ensuring the AgentDVR web extension entrypoint resolves to an actually shipped JS file.
Changes:
- Update
io-package.jsonto load the web extension frombuild/web.jsinstead of the missinglib/web.js. - Add the compiled web extension output (
build/web.js) and its sourcemap (build/web.js.map). - Disable ESLint and TypeScript checking for
src/web.ts.
Reviewed changes
Copilot reviewed 2 out of 4 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| src/web.ts | Disables linting and TS checking for the web extension source file. |
| io-package.json | Points webExtension to build/web.js so iobroker.web can require the module successfully. |
| build/web.js | Adds the compiled web extension implementation that iobroker.web will load. |
| build/web.js.map | Adds sourcemap for the compiled web extension. |
Files not reviewed (1)
- build/web.js: Generated file
Suppressed comments (1)
src/web.ts:2
/* eslint-disable */and// @ts-nocheckdisable all linting and all TypeScript checking for this file, which makes regressions in the web extension easy to miss. Prefer fixing the underlying TS issues (e.g., add explicit constructor parameter types and declareapp/adapter/_route/_authHeaderclass fields) and, if needed, disable only the specific ESLint rules that are still problematic instead of turning everything off.
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
|
Thanks for the fix! Before merging I dug into this a bit, and I don't think this is quite the right fix — let me explain what I found. What I checked:
So I suspect this was a stale/broken local install on your end (e.g. from before June 28) rather than a bug still present in the adapter. Merging this as-is would move a working, simple, git-portable file into the build pipeline for no confirmed benefit, and add generated build artifacts to track going forward. Could you confirm: which adapter version were you running when you hit this, and how was it installed (npm registry vs. a specific GitHub ref/tag)? If you can still reproduce this against current |
Cannot start extension "agent-dvr.0": Error: Cannot find module 'iobroker.agent-dvr/lib/web.js' Require stack: - /opt/iobroker/node_modules/iobroker.web/build/main.js