(WIP) Adds rule that password not appear in a blacklist#3
Open
mrclay wants to merge 1 commit intoircmaxell:masterfrom
Open
(WIP) Adds rule that password not appear in a blacklist#3mrclay wants to merge 1 commit intoircmaxell:masterfrom
mrclay wants to merge 1 commit intoircmaxell:masterfrom
Conversation
Owner
|
I would strongly suggest not dropping down to shell for this. First, it could expose the password to anyone on the server (watching the process list), as it's passed in an argument) Second, it's not portable As far as working in JS or not, it would be preferable to do so, but not necessary. |
Author
|
Yikes I didn't know cli args were easily snooped. |
aik099
pushed a commit
to aik099/password-policy
that referenced
this pull request
Mar 11, 2016
Extracted from ircmaxell#3
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Feedback welcomed. E.g. the JS version should not block the password, right? I added a few comments to help IDE comprehension. I know this needs tests.