Skip to content

[water][NFC] Remove unused AttrBasedElementsPerThreadOpTrait #644

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
tyb0807 wants to merge 1 commit into
base: main
Choose a base branch
from
+0 −44
Open

[water][NFC] Remove unused AttrBasedElementsPerThreadOpTrait #644

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
39 changes: 0 additions & 39 deletions water/include/water/Dialect/Wave/IR/WaveInterfaces.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -319,45 +319,6 @@ checkAndPropagateElementsPerThreadFromConstant(

} // namespace detail

// Trait implementing the methods of the WaveElementsPerThreadOpInterface based
// on the `elements_per_thead` attribute.
template <typename OpTy>
class AttrBasedElementsPerThreadOpTrait
: public mlir::OpTrait::TraitBase<OpTy, AttrBasedElementsPerThreadOpTrait> {
public:
// Propagate `elements_per_thread` value to results.
llvm::FailureOr<mlir::ChangeResult> propagateElementsPerThreadForward(
llvm::ArrayRef<ElementsPerThreadLatticeValue> operandTypes,
llvm::MutableArrayRef<ElementsPerThreadLatticeValue> resultTypes,
llvm::raw_ostream &errs) {
std::optional<int64_t> elementsPerThread =
llvm::cast<OpTy>(this->getOperation()).getElementsPerThread();
if (!elementsPerThread)
return mlir::ChangeResult::NoChange;

return detail::checkAndPropagateElementsPerThreadFromConstant(
ElementsPerThreadLatticeValue(*elementsPerThread), operandTypes,
resultTypes, "elements_per_thread attribute", "operand", "result",
errs);
}

// Propagate `elements_per_thread` value to operands.
llvm::FailureOr<mlir::ChangeResult> propagateElementsPerThreadBackward(
llvm::MutableArrayRef<ElementsPerThreadLatticeValue> operandTypes,
llvm::ArrayRef<ElementsPerThreadLatticeValue> resultTypes,
llvm::raw_ostream &errs) {
std::optional<int64_t> elementsPerThread =
llvm::cast<OpTy>(this->getOperation()).getElementsPerThread();
if (!elementsPerThread)
return mlir::ChangeResult::NoChange;

return detail::checkAndPropagateElementsPerThreadFromConstant(
ElementsPerThreadLatticeValue(*elementsPerThread), resultTypes,
operandTypes, "elements_per_thread attribute", "result", "operand",
errs);
}
};

// Trait implementing the methods of the WaveElementsPerThreadOpInterface with
// information flowing between operands and results.
template <typename OpTy>
Expand Down
5 changes: 0 additions & 5 deletions water/include/water/Dialect/Wave/IR/WaveInterfaces.td
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -64,11 +64,6 @@ def WaveElementsPerThreadOpInterface
let cppNamespace = "::wave";
}

def AttrBasedElementsPerThreadOpTrait
: NativeOpTrait<"AttrBasedElementsPerThreadOpTrait"> {
let cppNamespace = "::wave";
}

def NoOpElementsPerThreadOpTrait
: NativeOpTrait<"NoOpElementsPerThreadOpTrait"> {
let cppNamespace = "::wave";
Expand Down
Loading