[#112] Use rodsadmin connection for all quota operations (main)#146
Draft
korydraughn wants to merge 1 commit into
Draft
[#112] Use rodsadmin connection for all quota operations (main)#146korydraughn wants to merge 1 commit into
korydraughn wants to merge 1 commit into
Conversation
This commit resolves a problem involving the metadata guard rule engine
plugin and server redirects. The problem occurs under the following
conditions:
- The provider has the metadata guard plugin enabled
- The metadata guard is configured to only allow rodsadmin users to
modify metadata
- The consumer has the logical quotas plugin enabled
- User connects to consumer and places data into a collection
monitored by the logical quotas plugin, triggering a server redirect
- Quota values fail to be updated
The quota values are not updated because the logical quotas plugin
attempted to use the non-rodsadmin connection to update metadata
protected by the metadata guard plugin.
This commit resolves the problem by making the logical quotas plugin
connect to the server using the local rodsadmin account. This also
avoids permission issues related to checking quotas on parent
collections.
trel
reviewed
May 28, 2026
| addInxVal(&input.sqlCondInp, COL_COLL_NAME, fmt::format("= '{}'", _coll_path).c_str()); | ||
| addInxVal(&input.sqlCondInp, COL_META_COLL_ATTR_NAME, fmt::format("= '{}'", _quota_name).c_str()); | ||
| addInxVal( | ||
| &input.sqlCondInp, COL_COLL_NAME, fmt::format("= '{}'", irods::single_quotes_to_hex(_coll_path)).c_str()); |
Member
There was a problem hiding this comment.
the call to single_quotes_to_hex is new. that's unrelated to the new conn being used... right?
Collaborator
Author
There was a problem hiding this comment.
Can pull that out into a separate commit if desired. Probably a good idea to do that so it's more visible. Also, it's unrelated to the target issue.
I'll pull it into its own commit.
This was referenced May 28, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Existing tests pass.
Putting in draft until I can determine if a test can be added.