Skip to content

Remove year from license headers - #204

Merged
afritzler merged 1 commit into
mainfrom
chore/203-remove-year-license-headers
Sep 9, 2026
Merged

afritzler merged 1 commit into
mainfrom
chore/203-remove-year-license-headers

Conversation

@friegger

@friegger friegger commented Sep 9, 2026

Copy link
Copy Markdown
Contributor

Fixes #203

Summary by CodeRabbit

  • Documentation
    • Updated SPDX copyright attributions across project source, configuration, test, and documentation files.
    • Removed fixed copyright years and standardized attribution wording.
    • License identifiers remain unchanged.

Signed-off-by: Felix Riegger <felix.riegger@sap.com>
@friegger
friegger requested a review from a team as a code owner September 9, 2026 08:49
@github-actions github-actions Bot added the chore label Sep 9, 2026
@coderabbitai

coderabbitai Bot commented Sep 9, 2026

Copy link
Copy Markdown

Review Change StackReview Change Stack

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Advanced

Run ID: f9e91255-9d41-40a0-9896-562ec119888b

📥 Commits

Reviewing files that changed from the base of the PR and between f804b76 and 4de04ee.

📒 Files selected for processing (17)
  • REUSE.toml
  • Tiltfile.license
  • cmd/metal-cloud-controller-manager/main.go
  • hack/license-header.txt
  • pkg/cloudprovider/metal/cloud.go
  • pkg/cloudprovider/metal/cloud_test.go
  • pkg/cloudprovider/metal/config.go
  • pkg/cloudprovider/metal/config_test.go
  • pkg/cloudprovider/metal/constants.go
  • pkg/cloudprovider/metal/instances_v2.go
  • pkg/cloudprovider/metal/instances_v2_test.go
  • pkg/cloudprovider/metal/node_controller.go
  • pkg/cloudprovider/metal/node_controller_test.go
  • pkg/cloudprovider/metal/serverclaim_controller.go
  • pkg/cloudprovider/metal/serverclaim_controller_test.go
  • pkg/cloudprovider/metal/suite_test.go
  • pkg/version/version.go

Included review availability: Your plan provides up to 1 included review per hour; 0 remain after this review.


📝 Walkthrough

Walkthrough

The change removes fixed copyright years from REUSE configuration, the license header template, and existing SPDX headers in Go source and test files. License identifiers and credited organizations remain unchanged.

Changes

License header migration

Layer / File(s) Summary
License configuration and template updates
REUSE.toml, Tiltfile.license, hack/license-header.txt
Copyright text no longer contains fixed years. The Apache-2.0 identifiers remain unchanged.
Existing source header updates
cmd/metal-cloud-controller-manager/main.go, pkg/cloudprovider/metal/*, pkg/version/version.go
Existing Go source and test headers no longer contain fixed copyright years. No functional code changes were made.

Priority: ⬇️ Low

Estimated code review effort: 1 (Trivial) | ~3 minutes

Merge Risk: ⚪ Minimal · up to 4de04

This change removes fixed years from SPDX copyright text in configuration, templates, and source headers without changing runtime behavior or license identifiers. No current merge-readiness risk remains.

Suggested reviewers: afritzler

🚥 Pre-merge checks | ✅ 3 | ❌ 2

❌ Failed checks (2 warnings)

Check name Status Explanation Resolution
Description check ⚠️ Warning The description contains only the issue reference and omits the required Proposed Changes section and change summary. Add the required Proposed Changes section with concise bullets describing the header migration, affected files, license-marker preservation, and validation such as make check-license.
Linked Issues check ⚠️ Warning The changes address the main header migration and preserve the existing SPDX license identifiers. However, the linked issue also requires adding or documenting a safe rewrite process when existing hea… Add or document the safe header-rewrite process, and provide evidence that all tracked code files retain valid SPDX markers and that make check-license passes.
✅ Passed checks (3 passed)
Check name Status Explanation
Title check ✅ Passed The title clearly summarizes the main change: removing years from license headers.
Out of Scope Changes check ✅ Passed All summarized changes are limited to SPDX copyright-header updates and related REUSE/license-header configuration. No unrelated functional changes are present.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff. Analyzed 0 functions across 1…
Full details: Linked Issues check

Explanation

The changes address the main header migration and preserve the existing SPDX license identifiers. However, the linked issue also requires adding or documenting a safe rewrite process when existing headers are not updated by current tooling, and the provided changes do not show that requirement or evidence that make check-license passes.

  • Fix all pre-merge checks with AI
✨ Finishing Touches
📝 Generate docstrings
  • Create stacked PR
  • Commit on current branch
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch chore/203-remove-year-license-headers

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@afritzler
afritzler merged commit e67ba41 into main Sep 9, 2026
12 checks passed
@afritzler
afritzler deleted the chore/203-remove-year-license-headers branch September 9, 2026 09:07
@hardikdr hardikdr added the area/metal-automation Automation processes within the Metal project. label Sep 10, 2026
@hardikdr hardikdr added this to Roadmap Sep 10, 2026
@github-project-automation github-project-automation Bot moved this to Done in Roadmap Sep 10, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area/metal-automation Automation processes within the Metal project. chore

Projects

Status: Done

Development

Successfully merging this pull request may close these issues.

Remove years from existing license headers

3 participants