Re-link controller and scope 'messages' array objects#18
Open
smirciat wants to merge 5 commits intoirontec:masterfrom
Open
Re-link controller and scope 'messages' array objects#18smirciat wants to merge 5 commits intoirontec:masterfrom
smirciat wants to merge 5 commits intoirontec:masterfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This should solve Issue #4 for those who are experiencing it. I had a very basic setup of this directive and was unable to change the messages array in the directive controller through the sendMessage function. Adding this line forces the directive to resync the controller array object, which is displayed in the chat window, with the scope array object, which is generated outside of the directive. Not sure why the two way binding seems to fail in certain installations, but this fixes it with minimal penalty.