Repository navigation
Add the OV renderer lease and teleop-owned OVXR adapter - #8787
Draft
hougantc-nvda wants to merge 3 commits into
Draft
hougantc-nvda wants to merge 3 commits into
hougantc-nvda wants to merge 3 commits into
Conversation
This was referenced Oct 23, 2026
hougantc-nvda
force-pushed
the
hougantc/kitless-borrowed-renderer
branch
from
October 26, 2026 17:12
9e86c66 to
f63b4c2
Compare
This was referenced Oct 26, 2026
Consolidate the reviewed PR boundary before rebasing onto current main. Previous cumulative head: 12208c4 Signed-off-by: Hougant Chen <hougantc@nvidia.com>
Signed-off-by: Hougant Chen <hougantc@nvidia.com>
hougantc-nvda
force-pushed
the
hougantc/kitless-borrowed-renderer
branch
from
October 27, 2026 16:08
12208c4 to
6afe08b
Compare
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Connect kitless Isaac Lab teleoperation to Isaac Capture's OVXR session using the simulation's existing OVRTX renderer and OVStage. An explicit render lease lets Capture borrow those resources while Lab retains ownership and controls their lifetime.
The responsibilities are:
isaaclab_ov: owns the renderer, stage and scene publication. The generic lease serializes borrowed access without depending on XR or teleoperation.isaaclab_teleop: implements the OVXR adapter inov_libraries_xr.pyand bootstrap inovxr_session.py. It binds the environment, supplies XR render products, publishes scene/anchor updates and coordinates shutdown.Bootstrap reserves the lease before environment construction; the render worker starts afterward. Shutdown stops input consumers, closes the XR session and retires the lease before Lab destroys the renderer/stage. Failed retirement preserves resources for cleanup by their owning thread. The current lease supports one environment and a private rendering OVStage.
Lease/thread-transfer logic lives in
render_lease.py;publication_buffers.pyretains storage until native writes finish. Ordinary rendering stays inovrtx_renderer.py, with existing public imports preserved. Without a lease, normal rendering continues; while resources are borrowed, conflicting camera rendering, scene writes and destruction are rejected.See OVXR adapter ownership and lifecycle for details.
Dependencies: compatible Capture OVXR packages and the provider upgrade tracked in #8627. This PR leaves native-provider defaults unchanged. Until matching packages are released, use the source-build setup guide.
Type of change
Testing
Validation covers the cumulative stack, rebased on main
fa569a5501a36051ac855769f11f8c76f0ac0194with Capture95ba799fca650dd003fb5a2400f9ed4b1ed3cb2d; it is not an independent full-suite result for this PR.Open limits: cold attach over 300 seconds, intermittent GR1T2 first-Play recovery and slippery SO101 cubes remain unresolved; object retention/full task completion are not qualified. The separate Kit SDK audit has eight metadata mismatches. Full-repository, hosted-CI and arm64 coverage are not claimed. See #8791 for matched performance results and detailed validation limits.
Checklist
pre-commitchecks withuv run isaaclab --formatsource/<pkg>/changelog.d/for every touched package (do not editCHANGELOG.rstor bump package versions — CI handles that)CONTRIBUTORS.mdor my name already exists thereThe warnings checkbox remains open: dependency warnings and the separate Kit metadata audit are unresolved.