Fix isSectionEmpty to ignore Jira reference links and previous footer#21
Merged
Fix isSectionEmpty to ignore Jira reference links and previous footer#21
Conversation
- Strip reference-style link definitions (e.g. [IM-2611]: url added by Jira's GitHub integration) from section content before checking emptiness, so the last section (Testing Done) is not treated as filled just because Jira appended a link definition below it - Strip horizontal rules and our own footer text so a section that only received a footer (but no actual content) is retried on subsequent runs - Switch footer separator from --- to *** since GitHub drops --- when it follows HTML comment placeholders in certain contexts Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
LandonS23
approved these changes
Mar 4, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
[IM-2611]: https://...) to the PR body. Since Testing Done is the last section, theisSectionEmptyregex captures to end-of-string and picks up this link as content, making the section appear non-empty. Fixed by stripping reference-style links, HTML comments, horizontal rules, and our own previous footer text before checking emptiness — so only genuine user-written content counts.---dropped by GitHub: GitHub silently drops---from PR bodies when it follows an HTML comment in certain contexts. Switched to***which renders identically as a horizontal rule but survives GitHub's body processing.Test plan
***separator renders as a horizontal rule in the PR body🤖 Generated with Claude Code
📝 Auto-filled