Skip to content
This repository was archived by the owner on Aug 18, 2025. It is now read-only.

[v4] Improve performance of watch#117

Open
chan150 wants to merge 1 commit intoisar-community:mainfrom
chan150:main
Open

[v4] Improve performance of watch#117
chan150 wants to merge 1 commit intoisar-community:mainfrom
chan150:main

Conversation

@chan150
Copy link

@chan150 chan150 commented Jan 8, 2025

When using isar v4, streaming performance of watch is extremely degraded since it needs to create stream controller.
To solve this issue, we utilize both watchLazy and findAll instead of allocating stream controller.

@chan150 chan150 changed the title Improve performance of watch [v4] Improve performance of watch Jan 8, 2025
@vicenterusso
Copy link
Member

Hello @chan150,

I'm interested in understanding the performance degradation. Could you come up with a small reproduction?

@chan150
Copy link
Author

chan150 commented Jan 8, 2025

Here is a small reproduction:
https://github.com/chan150/isar_performance_degration_reproduction_example

2025-01-09.071016.mp4

@chan150
Copy link
Author

chan150 commented Jan 9, 2025

Screen Refresh Rate Benchmark:

flutter: Improved watch (ms.): 29
flutter: Original watch (ms.): 1809
flutter: Improved watch (ms.): 14
flutter: Original watch (ms.): 2446
flutter: Improved watch (ms.): 13
flutter: Original watch (ms.): 2695
flutter: Improved watch (ms.): 16
flutter: Original watch (ms.): 2063
flutter: Improved watch (ms.): 12
flutter: Original watch (ms.): 2027
flutter: Improved watch (ms.): 8
flutter: Original watch (ms.): 2573
flutter: Improved watch (ms.): 8
flutter: Original watch (ms.): 2520
flutter: Improved watch (ms.): 9
flutter: Original watch (ms.): 1904
flutter: Improved watch (ms.): 11
flutter: Original watch (ms.): 2024
flutter: Improved watch (ms.): 9
flutter: Original watch (ms.): 2007
flutter: Improved watch (ms.): 11
flutter: Original watch (ms.): 2476

@duocnguyen6799
Copy link

Is there any update on this?

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants