Conversation
Collaborator
|
@fedemp Sorry for the delay This needs a rebase against the latest release at https://github.com/isaul32/ckeditor5-math/releases/tag/v41.2.0 (so we catch the minor version bump at 41.2.0). |
Collaborator
Collaborator
|
@fedemp This needs the |
Collaborator
|
@fedemp In a normal JS/TS package, I would accept this as-is (I use berry on my own projects). I think we should focus on #99 first. My concern: As CKEditor5 isn't using yarn berry yet, it's unknown if this could cause unexpected friction due to:
I think since this is a CKEditor5 plugin, the more in line we are with https://github.com/ckeditor/ckeditor5, the less chance we'll hit conflicts when maintaining the package. |
Collaborator
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Since the project chose to use
yarnand also addyarn.lockto version control, I consider it a best practice to make clear which package manager the use. Since official yarn docs suggest using thestable/berryversion, I've set thepackageManageroption as so, and upgradedyarn.lock.