Conversation
There was a problem hiding this comment.
We should make a function for setting, obstacle->next. Also we're probably going to need set_obstacle_coordinates later on when we start moving the obstacle, I think we should leave it in there.
There was a problem hiding this comment.
Aside from that, all the changes look good.
There was a problem hiding this comment.
method to add new obcstacles will be covered in a separate PR.
There was a problem hiding this comment.
Regarding keeping this method, I don;t agree. It isn't used anywhere right now (and unused in the code I'm righting to generate new obstacles).
Having usused code, creates problems. We have to remember exactly where something was referenced and keep chaning it as we modify or create new code. Since its isnt used anywhere, the problems arent obvious either. When someone wants to use this, they can add it later. Its only 4 lines.
2 participants
The contruct_map method in main was not working. This changes them to be clearer. Also implemented obstacles for a map in a linked list.
quick review please @joeycarlos @rapjac @KCJWagner