Skip to content

fix(storage): keep remote copies out of cleanup - #19

Merged
ishaanko merged 4 commits into
mainfrom
fix/cleanup-keeps-remote
Sep 10, 2026
Merged

ishaanko merged 4 commits into
mainfrom
fix/cleanup-keeps-remote

Conversation

@ishaanko

Copy link
Copy Markdown
Owner

0.3.7.1 made storage cleanup delete the remote copy of an unprotected backup along with its local copies. Copies on GitHub are the off-site safety net and cleanup is about local space, so cleanup must not touch them.

Cleanup now frees space on this computer only. For a backup it lists it removes the ZIP and the local Git copy. Before the local Git copy goes, the executor proves the promised remote copy is really there (same check the protected path already used); a remote that lost the snapshot or cannot be reached fails that item with nothing deleted, so cleanup is never more destructive than the preview the user confirmed. A synchronized backup keeps its catalog record as a remote-only entry, so it stays listed, verifiable, and removable with Delete. Imported snapshots are not cleanup candidates because their sync status refers to the import source. A backup with no copy left anywhere still leaves the catalog with a deletion marker.

The two real-git integration tests now cover: local copies go while every remote ref and catalog row survives, and a backup with no remaining copy leaves the catalog while a synchronized one stays.

Prepares release 0.3.7.2.

Made by Claude Fable 5.1 in Claude Code.

🤖 Generated with Claude Code

0.3.7.1 made cleanup delete the remote copy of an unprotected backup. Cleanup
now frees space on this computer only. A synchronized backup keeps its catalog
record as a remote-only entry; the Delete button removes it from the remote.
@github-actions github-actions Bot added the size:L 100-499 effective changed lines (test files excluded in mixed PRs). label Sep 10, 2026
@greptile-apps

greptile-apps Bot commented Sep 10, 2026

Copy link
Copy Markdown

RetriggerConfidence Score: 5/5

Safe to merge; no blocking issues remain.

Summary

  • Removes local ZIP and Git copies without deleting remote refs.
  • Verifies a promised synchronized remote copy before removing its local Git snapshot.
  • Excludes imported snapshots from managed remote-copy assumptions.
  • Updates cleanup messaging, documentation, release metadata, and integration coverage.

Reviews (2) · Last reviewed commit: "docs(storage): say cleanup reads the rem..."

Comment thread src/main/java/dev/ishaanko/worldarchive/storage/management/CleanupExecutor.java Outdated
@ishaanko
ishaanko merged commit 6dd0181 into main Sep 10, 2026
3 checks passed
@ishaanko
ishaanko deleted the fix/cleanup-keeps-remote branch September 10, 2026 22:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

size:L 100-499 effective changed lines (test files excluded in mixed PRs).

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant