fix(storage): keep remote copies out of cleanup - #19
Merged
Merged
Conversation
0.3.7.1 made cleanup delete the remote copy of an unprotected backup. Cleanup now frees space on this computer only. A synchronized backup keeps its catalog record as a remote-only entry; the Delete button removes it from the remote.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
0.3.7.1 made storage cleanup delete the remote copy of an unprotected backup along with its local copies. Copies on GitHub are the off-site safety net and cleanup is about local space, so cleanup must not touch them.
Cleanup now frees space on this computer only. For a backup it lists it removes the ZIP and the local Git copy. Before the local Git copy goes, the executor proves the promised remote copy is really there (same check the protected path already used); a remote that lost the snapshot or cannot be reached fails that item with nothing deleted, so cleanup is never more destructive than the preview the user confirmed. A synchronized backup keeps its catalog record as a remote-only entry, so it stays listed, verifiable, and removable with Delete. Imported snapshots are not cleanup candidates because their sync status refers to the import source. A backup with no copy left anywhere still leaves the catalog with a deletion marker.
The two real-git integration tests now cover: local copies go while every remote ref and catalog row survives, and a backup with no remaining copy leaves the catalog while a synchronized one stays.
Prepares release 0.3.7.2.
Made by Claude Fable 5.1 in Claude Code.
🤖 Generated with Claude Code