Skip to content

fix(ui): keep the backups icon aligned when other mods add icons late - #20

Merged
ishaanko merged 3 commits into
mainfrom
fix/icon-row-late-icons
Sep 14, 2026
Merged

ishaanko merged 3 commits into
mainfrom
fix/icon-row-late-icons

Conversation

@ishaanko

Copy link
Copy Markdown
Owner

The World Backups icon on the pause and title screens was placed once, right after the screen initialized. A mod whose screen hook ran after ours could add an icon or recenter the row, which left our icon off to the right of the others.

The row is now laid out again before every frame: every other square icon is collected, the backups icon is appended, and the row is recentered around the center it had before we joined. The result is the same as before when nobody else touches the row, and it stays aligned no matter which mod ran last.

Made with Claude Fable 5.1 in Claude Code.

🤖 Generated with Claude Code

@github-actions github-actions Bot added the size:M 30-99 effective changed lines (test files excluded in mixed PRs). label Sep 14, 2026
@greptile-apps

greptile-apps Bot commented Sep 14, 2026

Copy link
Copy Markdown

RetriggerConfidence Score: 5/5

Safe to merge.

Summary

  • The World Backups shortcut remains aligned with the selected icon row when other mods change that row after screen initialization. Frame-time layout only considers square buttons at the shortcut’s existing Y coordinate, preventing controls on other rows from being moved.

Reviews (3) · Last reviewed commit: "chore(release): prepare 0.3.7.3"

Comment thread src/client/java/dev/ishaanko/worldarchive/ui/IconRowBackupIntegration.java Outdated
@ishaanko
ishaanko merged commit 123ccf8 into main Sep 14, 2026
3 checks passed
@ishaanko
ishaanko deleted the fix/icon-row-late-icons branch September 14, 2026 18:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

size:M 30-99 effective changed lines (test files excluded in mixed PRs).

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant