fix(ui): keep the backups icon aligned when other mods add icons late - #20
Merged
Merged
Conversation
…mods add icons late
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The World Backups icon on the pause and title screens was placed once, right after the screen initialized. A mod whose screen hook ran after ours could add an icon or recenter the row, which left our icon off to the right of the others.
The row is now laid out again before every frame: every other square icon is collected, the backups icon is appended, and the row is recentered around the center it had before we joined. The result is the same as before when nobody else touches the row, and it stays aligned no matter which mod ran last.
Made with Claude Fable 5.1 in Claude Code.
🤖 Generated with Claude Code