Skip to content

feat(ui): add a Cancel button to manual backups - #21

Open
ishaanko wants to merge 3 commits into
mainfrom
feat/cancel-manual-backup
Open

ishaanko wants to merge 3 commits into
mainfrom
feat/cancel-manual-backup

Conversation

@ishaanko

Copy link
Copy Markdown
Owner

A manual backup started from the Create Backup screen could not be stopped. The screen showed "Please wait" until the backup finished, and for a live world the runtime handed the screen a result stage that ignored cancel.

The operation screen now shows a Cancel button while a backup creation runs. Cancel stops the running stage. For a live world the runtime returns a result view whose cancel goes through the same handler as the world-exit toast: it interrupts the capture thread while the world is copied, and cancels the coordinator operation once dispatched. The coordinator already removes the private capture and the partial ZIP, interrupts the Git write and cleans its staging, and keeps a destination that had finished before the stop. The screen reports "Backup cancelled" instead of a failure and offers no retry.

The cancellation check moved into AsyncTasks so the toast and the screen share one definition; a unit test covers it. The runtime and screen changes need the Minecraft client, so they were verified by build only.

Made with Claude Fable 5.1 in Claude Code.

🤖 Generated with Claude Code

@github-actions github-actions Bot added the size:L 100-499 effective changed lines (test files excluded in mixed PRs). label Sep 14, 2026
@greptile-apps

greptile-apps Bot commented Sep 14, 2026

Copy link
Copy Markdown

RetriggerConfidence Score: 5/5

Safe to merge.

Summary

This update adds cancellation support for manual live-world backups while keeping the operation result aligned with the coordinator’s actual outcome. A cancellation request is forwarded without cancelling the result view itself, so a backup that has already entered recording can still report its recorded result.

Reviews (3) · Last reviewed commit: "test(zip): prove a cancelled backup leav..."

Comment thread src/client/java/dev/ishaanko/worldarchive/runtime/RuntimeLifecycle.java Outdated
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

size:L 100-499 effective changed lines (test files excluded in mixed PRs).

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant