Conversation
Update the toolchain to Minecraft 26.3, Fabric Loader 0.19.5, Fabric API 0.160.5, Loom 1.18.1, and Gradle 9.7.1. Minecraft 26.3 replaced GLFW and tinyfd with SDL3, so the folder picker now uses the SDL dialog, and Util.OS.openPath became Blaze3D.openPath. Mod Menu has no 26.3 release yet, so it is now optional. Fix the defects a full source audit found, with tests for each behavior change: .gitignore files dropping world files from Git snapshots, secret redaction corrupting the snapshot manifest, the credential filter rejecting ordinary world names and config paths, batch delete burning confirmation tokens of worlds that never started, cleanup failing on records with a failed destination, the schema 4 migration dropping per-world ZIP folders, plus the smaller portability, crash, and settings-screen fixes listed in CHANGELOG.md. Remove dead code and duplicated helpers found on the way.
|
Also drop the world page's transient ZIP override state when the settings draft is replaced, so Restore defaults clears the checkbox.
A zero-destination backup removes its catalog record and then rethrows on cancellation, so handing its token back let a retry fail forever. Also bound the digits the Git version probe accepts.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
Minecraft 26.3 is out, and the mod did not compile against it: 26.3 replaced GLFW and tinyfd with SDL3 (the folder picker used tinyfd), and
Util.OS.openPathis gone. Mod Menu has no 26.3 release yet, so a hard dependency on it would block every install.A full audit of every source file also found a set of real defects. The worst ones: a
.gitignoreinside a world (common in datapacks) silently dropped files from Git snapshots and then failed every backup of that world; secret redaction ran over parsed git output, so a world namedSecret: Baseproduced an unreadable snapshot manifest; the credential filter rejected ordinary names such asTask100% Done, so those worlds could never finish a ZIP backup, and rejected config paths such asDisk-90%at load time after accepting them at save time.Fix
Blaze3D.openPathopens folders. Mod Menu issuggests, and the title-screen icon reaches the mod without it.git add --forceso excludes never drop world files; pattern redaction only on displayed text and truncated output; bounded repository lock wait; temp trees always removed;core.longpathson; Git 2.29 or newer required and reported by the tool probe.\non every platform; catalog and inventory ceilings raised past 64 MiB; orphaned capture markers are reclaimed.Every behavior change has a focused test.
./gradlew buildpasses with 490 tests. Not verified in game.Changes made by Claude Fable 5.1 running in Claude Code through T3 Code.
🤖 Generated with Claude Code