Conversation
modeling/datasets.py
Outdated
| @@ -219,31 +206,29 @@ def __init__( | |||
| all_embeddings_path, | |||
| train_parts=(0, 17), | |||
Collaborator
There was a problem hiding this comment.
Let's change it to parts from paper. Train -- 0-8, gap -- 8-9, eval -- 9-10
modeling/training.py
Outdated
| for key, value in metrics.items(): | ||
| self.writer.add_scalar(key, value, step) | ||
|
|
||
| def get_timestamp(self): |
Collaborator
There was a problem hiding this comment.
Let's make it a property and use def timestamp instead of def get_timestamp
Owner
Author
There was a problem hiding this comment.
inlined it and now use it as property
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Early stopping is not needed and validation part can confuse