Skip to content

Add adjacency effects to Lake Mary example - #54

Open
brentwilder wants to merge 3 commits into
isofit:mainfrom
brentwilder:adjacency-effects-lake-mary
Open

Add adjacency effects to Lake Mary example#54
brentwilder wants to merge 3 commits into
isofit:mainfrom
brentwilder:adjacency-effects-lake-mary

Conversation

@brentwilder

Copy link
Copy Markdown
Contributor

Expands the Lake Mary test to also include the adjacency effects improvements developed from 974.

@brentwilder brentwilder changed the title Add adjacency effects to default args Add adjacency effects to default args for Lake Mary Jun 15, 2026
@pgbrodrick

Copy link
Copy Markdown
Contributor

Needs 974 before merging.

@brentwilder
brentwilder force-pushed the adjacency-effects-lake-mary branch from 6b757d1 to 245e933 Compare July 27, 2026 16:04
@brentwilder

Copy link
Copy Markdown
Contributor Author

@unbohn / @jammont revisiting this from our conversation last week. The pre-computed _bgrfl.hdr data exists in the examples data for Lake Mary, and apply_oe is written in a way that it will leverage this file without needing the entire imagecube for this exact purpose.

My main question is if we wanted to include this in the Lake Mary test as the default arg, or to somehow test both ways (on and off)?

@unbohn

unbohn commented Jul 27, 2026

Copy link
Copy Markdown
Collaborator

@brentwilder I'd suggest to keep the test simple for now and include the pre-computed data as default arg. But happy to go other ways, too!

@jammont

jammont commented Jul 27, 2026

Copy link
Copy Markdown
Collaborator

To test both ways, could just add another template like bgrfl.args.json that includes this argument. ISOFIT auto-detects all of the template files and constructs a script for each one

@unbohn

unbohn commented Jul 27, 2026

Copy link
Copy Markdown
Collaborator

@jammont Sounds good to me as well!

@brentwilder

Copy link
Copy Markdown
Contributor Author

Okay, based on our conversation from last week I added a prebuilt LUT via srtmnet (along with the lut_config file). This way we can quickly call both modes default.args.json and bgrfl.args.json without rebuilding the lut each time.

I also addressed #57 by bringing in the most recent surface from the emit sds.

I don't have a good feel for how the data should be structured, and so I just have all of the files in the /templates directory. Please let me know if this is incorrect.

@unbohn

unbohn commented Jul 30, 2026

Copy link
Copy Markdown
Collaborator

Thanks, @brentwilder! This looks good. The /templates directory makes sense for all the json files. However, we'd need to think about the location of the prebuilt LUT since it's not really a template. Maybe we could do two subdirectories under the Lake Mary parent directory, /templates and /luts? @jammont What do you think?

@brentwilder brentwilder changed the title Add adjacency effects to default args for Lake Mary Add adjacency effects to Lake Mary example Aug 17, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants