fix: prevent potential MEA hang when too many traces are processed #78
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
If a verification result produces a large number of error traces, the per-process MEA resource queue may overflow, causing the entire process to hang.
Otherwise, deadlocks may occur in some cases - one process can block on a queue operation while the main process is stuck in join().
…s in MEA Proofs are not compared at the moment, but this may be needed in the future. Passing the full trace to the cache makes little sense, since currently proofs are represented as conditions and invariants (and invariants may be absent). Therefore, conditions are the best candidate for cached results to enable comparison of different proof versions.
According to the SV-COMP 1.0 format, traces are stored in GraphML files. If a verifier produces additional files starting with "witness...", they may be incorrectly processed as witnesses.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If a verification result produces a large number of error traces,
the per-process MEA resource queue may overflow, causing the entire
process to hang.