build: fail loudly when the OpenWrt make fails instead of exiting silently#47
Open
ispyisail wants to merge 1 commit into
Open
build: fail loudly when the OpenWrt make fails instead of exiting silently#47ispyisail wants to merge 1 commit into
ispyisail wants to merge 1 commit into
Conversation
…ently Neither build.sh nor rebuild.sh checked the main OpenWrt make's exit status. On a failed make they fell through to the image_files check, whose bare "exit" printed nothing -- a failed build was indistinguishable from the script simply stopping, and the only way to find the real error was re-running make directly. This masked a real package failure across multiple full builds before anyone caught it. Check the make exit status right after each invocation and bail with the status and a pointer at the failing step; give the previously silent "no image files after build" exits a real error message too.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Stacked on #43 — base branch is
openwrt-2512(the 25.12 bump), notmaster. Merge #43 first; this rebases cleanly onto master afterward.Neither
build.shnorrebuild.shchecked the main OpenWrtmake's exit status. On a failedmake, both fell through to their "did we produce any images" check, whose bareexiton failure printed nothing — a genuine build failure was indistinguishable from the script just stopping, with no indication of what broke or where. This directly cost real debugging time during the 25.12 bump work: a package failure was masked across several full-build attempts before it was found by bypassing both scripts and runningmake V=sdirectly.Checks the
makeexit status immediately after each invocation and bails with the exit code and a pointer at the next diagnostic step (make V=sin the target's-srcdirectory); gives the previously-silent "no image files after build" exit paths a real error message too, for the same reason.