Return API errors from IstioRevision tag conflict check - #2293
Return API errors from IstioRevision tag conflict check#2293sridhargaddam wants to merge 1 commit into
Conversation
validateNoTagConflict only reacted when Client.Get returned no error, so a transient API error looked the same as "no tag with this name". That let a conflicting IstioRevision pass validation and install, fighting an identically-named IstioRevisionTag over the same webhook resources. Now we return any non-NotFound error, matching the check that already exists in the IstioRevisionTag controller. Fixes: istio-ecosystem#2082 Signed-off-by: Sridhar Gaddam <sgaddam@redhat.com>
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #2293 +/- ##
==========================================
+ Coverage 87.81% 88.12% +0.30%
==========================================
Files 56 56
Lines 2658 2660 +2
==========================================
+ Hits 2334 2344 +10
+ Misses 324 316 -8
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
|
/retest |
|
/test e2e-kind-dualstack |
|
@sridhargaddam: The following test failed, say
DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
4 participants
validateNoTagConflict only reacted when Client.Get returned no error, so a transient API error looked the same as "no tag with this name". That let a conflicting IstioRevision pass validation and install, fighting an identically-named IstioRevisionTag over the same webhook resources. Now we return any non-NotFound error, matching the check that already exists in the IstioRevisionTag controller.
Fixes: #2082