Skip to content

[release-1.31] test: skip TLS profile e2e tests when APIServer is not writable - #2317

Open
unsortedhashsets wants to merge 1 commit into
istio-ecosystem:release-1.31from
unsortedhashsets:cherry-pick-2313-release-1.31
Open

[release-1.31] test: skip TLS profile e2e tests when APIServer is not writable#2317
unsortedhashsets wants to merge 1 commit into
istio-ecosystem:release-1.31from
unsortedhashsets:cherry-pick-2313-release-1.31

Conversation

@unsortedhashsets

Copy link
Copy Markdown
Contributor

PR for release-1.31

What type of PR is this?

  • Enhancement / New Feature
  • Bug Fix
  • Refactor
  • Optimization
  • Test
  • Documentation Update

What this PR does / why we need it:

Backport of #2313 to release-1.31.

The TLS profile tests update the cluster-scoped APIServer resource, which managed clusters (e.g. ROSA/OSD) reject via Red Hat SRE admission webhooks with a Forbidden error. Instead of enumerating cluster types, the tls-profile BeforeAll now probes writability directly with a no-op server-side dry-run update and skips on Forbidden, persisting nothing. This generalises the existing hosted-cluster guard and covers any cluster where the resource is not manageable, while self-managed OpenShift continues to run the tests.

Which issue(s) this PR fixes:

Fixes #

Related Issue/PR #2313

Additional information:

Cherry-picked commit:

The hosted-cluster guard (#1873) is already present on release-1.31, so the probe slots in after it with no conflicts.

Verified: e2e test package compiles (go test -tags e2e -c ./tests/e2e/operator/); no conflicts.

The TLS profile tests update the cluster-scoped APIServer resource, which managed clusters (e.g. ROSA/OSD) reject via Red Hat SRE admission webhooks with a Forbidden error. Instead of enumerating cluster types, the tls-profile BeforeAll now probes writability directly with a no-op server-side dry-run update and skips on Forbidden, persisting nothing. This generalises the existing hosted-cluster guard and covers any cluster where the resource is not manageable, while self-managed OpenShift continues to run the tests.

Signed-off-by: Mikhail Abramov <mabramov@redhat.com>
@istio-testing

Copy link
Copy Markdown
Collaborator

Hi @unsortedhashsets. Thanks for your PR.

I'm waiting for a istio-ecosystem or istio member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work.

Tip

We noticed you've done this a few times! Consider joining the org to skip this step and gain /lgtm and other bot rights. We recommend asking approvers on your previous PRs to sponsor you.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@mkralik3

mkralik3 commented Sep 4, 2026

Copy link
Copy Markdown
Contributor

/ok-to-test

@dgn dgn changed the title test: skip TLS profile e2e tests when APIServer is not writable [release-1.31] test: skip TLS profile e2e tests when APIServer is not writable Sep 4, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants