Skip to content

Fixing legacy compatibility for old modutils with missing hooks #28

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
DasKeifer wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Fixing legacy compatibility for old modutils with missing hooks #28

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 3 additions & 1 deletion scripts/internal.lua
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -27,7 +27,9 @@ function internal:buildBroadcastFunc(hooksField, argsFunc)
end

for i, extObj in ipairs(modApiExt_internal.extObjects) do
if extObj[hooksField] then
-- Only process hooks that are directly on this extObj, not inherited via metatable
-- This prevents proxies from accidentally firing hooks they don't actually support
if rawget(extObj, hooksField) then
for j, hook in ipairs(extObj[hooksField]) do
-- invoke the hook in a xpcall, since errors in SkillEffect
-- scripts fail silently, making debugging a nightmare.
Expand Down