4 small fixes #211
Open
4 small fixes #211
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 4 commits
December 8, 2025 12:08
E721 Use `is` and `is not` for type comparisons, or `isinstance()` for isinstance checks Signed-off-by: Philipp Hahn <p.hahn@avm.de>
> shtab/__main__.py:8: error: "main" does not return a value (it only ever returns None) Signed-off-by: Philipp Hahn <p.hahn@avm.de>
ArgumentParser._get_optional_actions() will always return instances of `Action` and never `SUPPRESS`, which is a `str`. Signed-off-by: Philipp Hahn <p.hahn@avm.de>
Also handle input redirection. Also handle other file descriptors than STDOUT and STDERR. Signed-off-by: Philipp Hahn <p.hahn@avm.de>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is the next part from my original #196 containing 4 small fixes from running
ruffandmypy.