Skip to content

Infer tendency type by keys - #183

Merged
SBlokhuizen merged 7 commits into
developfrom
feature/tendency-inference
Aug 6, 2026
Merged

Infer tendency type by keys#183
SBlokhuizen merged 7 commits into
developfrom
feature/tendency-inference

Conversation

@SBlokhuizen

@SBlokhuizen SBlokhuizen commented Jul 31, 2026

Copy link
Copy Markdown
Collaborator

Infer a tendency's type based on what keys are present in the tendency.

@SBlokhuizen
SBlokhuizen marked this pull request as ready for review August 3, 2026 09:15
@SBlokhuizen
SBlokhuizen force-pushed the feature/tendency-inference branch from 8eba10b to a4bcf00 Compare August 5, 2026 11:36

@maarten-ic maarten-ic left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some questions, let me know what you think!

Comment thread waveform_editor/waveform.py Outdated
Comment thread waveform_editor/waveform.py Outdated
Comment thread waveform_editor/waveform.py Outdated
@SBlokhuizen
SBlokhuizen requested a review from maarten-ic August 5, 2026 14:38
Comment thread waveform_editor/waveform.py Outdated

@maarten-ic maarten-ic left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice, always good to see complexity reduced! 😄

@SBlokhuizen
SBlokhuizen requested a review from maarten-ic August 6, 2026 07:59
Comment thread waveform_editor/waveform.py Outdated
Co-authored-by: Maarten Sebregts <110895564+maarten-ic@users.noreply.github.com>
@SBlokhuizen
SBlokhuizen requested a review from maarten-ic August 6, 2026 09:32

@maarten-ic maarten-ic left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@SBlokhuizen
SBlokhuizen merged commit 8886b04 into develop Aug 6, 2026
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants