Shorthand notation - #185
Open
SBlokhuizen wants to merge 2 commits into
Open
Conversation
SBlokhuizen
marked this pull request as ready for review
August 3, 2026 12:25
SBlokhuizen
requested review from
MireilleSchneider and
maarten-ic
as code owners
August 3, 2026 12:25
SBlokhuizen
force-pushed
the
feature/shorthand-notation
branch
from
August 5, 2026 11:37
6e12967 to
99f978a
Compare
maarten-ic
reviewed
Aug 5, 2026
Comment on lines
+175
to
+187
| waveform = Waveform( | ||
| waveform=[ | ||
| { | ||
| "user_type": "constant", | ||
| "user_value": waveform, | ||
| "line_number": line_number, | ||
| } | ||
| ], | ||
| yaml_str=yaml_str, | ||
| line_number=line_number, | ||
| name=name, | ||
| dd_version=dd_version, | ||
| ) |
Collaborator
There was a problem hiding this comment.
Is this exported to a waveform with single constant tendency again?
Would it be better to have a ConstantWaveform class instead?
Collaborator
There was a problem hiding this comment.
Btw, this used to be handled as a derived waveform without dependencies, right? Can you explain why we need this distinction?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Updates parsing of shorthand string, float and integer notation as a waveform containing a single constant tendency.