-
Notifications
You must be signed in to change notification settings - Fork 3
Documentation #27
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Documentation #27
Changes from all commits
Commits
Show all changes
20 commits
Select commit
Hold shift + click to select a range
91a444b
Initial commit. Clean up, make it uniform.
simonforsberg aa7a75b
Start add Java Docs, remove unused methods, remove AppIT class, updat…
simonforsberg 4cbf51e
CodeRabbit feedback
simonforsberg 0c48772
Remove unused metod findSongsInPlaylist
simonforsberg c7306c8
Add Javadocs for MyPod.java
simonforsberg 8fc88a0
Add Javadocs for App.jav
simonforsberg 9c313b5
Add Javadocs for DatabaseInitializer
simonforsberg 4b04b77
Add Javadocs for EntityManagerFactoryProvider
simonforsberg 2b92789
Add Javadocs for ItunesApiClient
simonforsberg a3bf2b1
Add Javadocs for ItunesDTO
simonforsberg 6a30bc1
Add Javadocs for PersistenceManager
simonforsberg cac4939
Add Javadocs for test suit
simonforsberg 43becea
CodeRabbit feedback
simonforsberg a4a1be8
Add Javadocs for entities
simonforsberg d1b4ba6
Add Javadocs for repositories
simonforsberg a39fafb
Fix typos
simonforsberg a356dc6
Fix typos, translate comments, delete unused imports
simonforsberg e556f37
Fix typos
simonforsberg 55f414e
Fix: Select first playlist (Library) after data loads to avoid empty …
simonforsberg 1f7322c
Add error handling for deleteSelectedPlaylist, add error handling for…
simonforsberg File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🧩 Analysis chain
🏁 Script executed:
fd -type f -name "*PlaylistRepository*" --extension javaRepository: ithsjava25/project-jpa-mypod-d
Length of output: 244
🏁 Script executed:
fd -type f -name "*PlaylistRepository*" -e javaRepository: ithsjava25/project-jpa-mypod-d
Length of output: 244
🏁 Script executed:
fd -t f -name "*PlaylistRepository*" -e javaRepository: ithsjava25/project-jpa-mypod-d
Length of output: 304
🏁 Script executed:
Repository: ithsjava25/project-jpa-mypod-d
Length of output: 187
🏁 Script executed:
Repository: ithsjava25/project-jpa-mypod-d
Length of output: 14264
🏁 Script executed:
sed -n '100,120p' src/main/java/org/example/DatabaseInitializer.javaRepository: ithsjava25/project-jpa-mypod-d
Length of output: 676
Add name-based playlist existence check instead of hardcoded IDs.
Using hardcoded IDs (
1L,2L) to check for playlist existence at lines 107 and 111 is fragile and assumes specific auto-increment behavior. If the database is reset or IDs are assigned differently (e.g., in a different order), these checks will fail silently and create duplicate "Library" and "Favorites" playlists.Implement an
existsByName(String name)method inPlaylistRepositoryand use it instead:Suggested fix
Add to
PlaylistRepositoryinterface:And implement in
PlaylistRepositoryImpl:🤖 Prompt for AI Agents