chore(routines): remove never-attached monitoring routine scripts, guard routines/ tracking - #5709
Merged
Merged
Conversation
… guard routines/ against tracking routines/ is operator-private per docs/source-of-truth.md, yet ten scripts (local-worktree-gc.js and routines/monitoring/*) were tracked. None was ever attached as a production routine (no routines row, no launchd plist, zero runs), so they were dead code shipped on every deploy. - remove the ten tracked scripts plus the policy/python tests that only exercised them and the three routine docs that described them - replace their ci-script-checks.sh invocations with a guard that fails when `git ls-files routines` is non-empty - annotate the automation-candidate / observation-provider PRD+spec docs that the routine-side implementation is gone (Rust API/DB surface stays) Operator-local dead scripts (migrated-launchd briefings, warmup, examples) were removed from the runtime and workspace trees separately; the warmup-obiseo-session routine row was detached and deleted via the API. Refs #5707 #5708 Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
routines/is operator-private (docs/source-of-truth.md:git ls-files routinesmust be empty), but 10 scripts were tracked:local-worktree-gc.jsandroutines/monitoring/*(automation-candidate detector/recommender/executor ×2, daily-log-digest js+py, log_digest_issue_drafts.py, weekly_churn_audit.py, local_worktree_inventory.js). Live audit 2026-09-05: none has aroutinesDB row, no launchd plist, zero runs ever — dead code staged on every deploy.What
git rmthe 10 scripts, the 8policies/__tests__files and 2tests/python files that only exercised them, anddocs/routines/{daily-log-digest,local-worktree-inventory,weekly-churn-audit}.md.scripts/ci-script-checks.sh: drop the two removed unittest/node invocations; add a guard that fails whengit ls-files routinesis non-empty.Not in this PR
automation_candidatesAPI/DB and the loader's bundled-helper special-casing stay (operators may still ship local monitoring scripts). Follow-up decision: retire that API surface or re-implement the executor.~/.adk/release/routinesand the workspace tree out-of-band; warmup routine row deleted via API.Verification
node --test policies/__tests__/*.test.jsgreen after removal.bash -nok.src/**unchanged → low-risk; Rust build/tests delegated to required CI.tests.test_agent_maintenance_docsreports a migration-0093 rollout-contract error on main too.Refs #5707 #5708
🤖 Generated with Claude Code