Repository navigation
Gate onboarding engine step on local model download - #22
Merged
Merged
Conversation
Block Continue on the engine step until the selected local MLX model finishes downloading, with a real progress bar, so the practice step never fires against a missing model and errors out. Cloud and already-installed engines still advance freely; a failed download proceeds on the Apple fallback. Runner script emits aggregate PROGRESS lines; installer parses them into a published fraction driving the bar. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Blocks Continue on the onboarding engine step until the selected local MLX model finishes downloading, so users can no longer advance into the practice/test step against a missing model and hit a scary error. Adds a real progress bar with percentage while the model downloads.
The runner script (
mlx_stt_infer.py) now emits aggregatePROGRESS <fraction>lines from a custom tqdm class;MLXModelInstallerparses them from stdout into a publishedinstallProgressfraction that drives the bar. Cloud and already-installed engines still advance freely, and a failed download proceeds on the Apple built-in fallback.🤖 Generated with Claude Code