Skip to content

Fix dock review findings - #2

Merged
itscallssh merged 2 commits into
dock/improve-omarchy-dockfrom
itscallssh-dock-review-fixes
Oct 22, 2026
Merged

itscallssh merged 2 commits into
dock/improve-omarchy-dockfrom
itscallssh-dock-review-fixes

Conversation

@itscallssh

@itscallssh itscallssh commented Oct 22, 2026 •

Copy link
Copy Markdown
Owner

The dock review identified issues that could launch app processes in the shell's service, switch workspaces while minimizing, omit English labels, and clip long tooltip titles.

This keeps New Window behavior while launching commands through the app library's uwsm-app scope helper, minimizes only windows on the active workspace, adds the missing English catalog entries, and bounds and elides vertical tooltip headings.

Checks: ./test/shell.d/dock-test.sh, I18N_STRUCTURAL=1 ./test/shell.d/i18n-test.sh, and git diff --check passed.

RetriggerView in GreptileConfidence Score: 5/5

The PR appears safe to merge; the previous menu issue is fixed.

Summary

The PR launches new windows through uwsm-app, limits minimization to the active workspace, adds English dock labels, and shortens long vertical tooltip headings.

  • The dock opens new app windows through the app’s own scope.
  • The dock’s Minimize action stays on the active workspace.
  • Long titles fit inside vertical dock tooltips.
  • The dock’s English labels include “Apps” and “Minimize.”

Reviews (2) · Last reviewed commit: "Align minimize menu with active workspac..." · Reviewed by Greptile

Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
Comment thread shell/plugins/dock/Dock.qml Resolved
Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
@itscallssh
itscallssh merged commit 6a57d4b into dock/improve-omarchy-dock Oct 22, 2026
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant