Upload the best fitting video variant - #24
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changed
0.6.30and rebuild the userscriptWhy
The previous fixed 8 MiB per-file limit rejected the referenced 15.3 MB video after downloading it, even though it fits Discord's current request allowance. It also discarded the smaller MP4 variants that could have served as fallback choices.
User impact
Video shares now prefer the clean native Discord player. The userscript tries the best fitting X-hosted MP4 variant automatically and only displays a CDN fallback link when no variant can be uploaded.
Validation
npm test— 98 tests passednpm run checkgit diff --checkTrust and release impact
HEADrequests to the already-allowed X video CDN before media downloadsv0.6.30through the existing release workflow