Respect Discord attachment limits - #25
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changed
0.6.31and rebuild the userscriptRoot cause
v0.6.30treated Discord's 25 MiB message request limit as though it were the per-file attachment limit. Discord currently applies a default 10 MiB limit to each webhook attachment, so the selected 15.3 MB MP4 was rejected withRequest entity too large.User impact
The reported video now uploads through the clean native Discord player using the highest-quality MP4 variant that fits the default webhook attachment limit. The CDN link remains hidden when an eligible variant is available.
Validation
npm test— 98 tests passednpm run checkgit diff --checkTrust and release impact
v0.6.31through the existing release workflow