Agent/fix player exp progress - #67
Conversation
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 1394c9de1e
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| patchDraft({ uiTheme }); | ||
| const saved = await window.loremasterDesktop?.updateSettings({ uiTheme }); | ||
| if (saved) { | ||
| setDraft(saved); |
There was a problem hiding this comment.
If a user edits any deferred HUD or alert preference and then selects a theme before clicking “SAVE HUD + ALERT SETTINGS,” saved contains the previously persisted settings because the theme IPC call only submits uiTheme. Replacing the entire draft with that response silently discards the pending composition, toggle, threshold, and placement edits; update only the draft theme (or merge the response without overwriting dirty fields).
Useful? React with 👍 / 👎.
Sync upstream PR itsspin#67: native themes, SpinTexture, alert sounds
1 participant
No description provided.