-
-
Notifications
You must be signed in to change notification settings - Fork 27
Postnl support #178
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Postnl support #178
Conversation
837467d to
7c4e0ea
Compare
|
I've been using this regularly since I opened the PR, and it's been working well, so I'd be happy to merge this and maintain this particular API as needed |
|
That's annoying. It's your repo, so up to you whether to remove it, I just added it to indicate that I'm happy to deal with issues related to this particular delivery service if any arise |
|
In the sense of how we Dutchies say: "asking is free". Any change this is going to be merched soon (without the codeowners file if needed), or that @MaeIsBad can upload an apk with this patch? I get them more often, but I've currently got 7 PostNL packages to wait for atm so It'll be extra useful right now and I don't have stuff around to build it myself atm 😅. |
|
Here you go: https://0x0.st/KfM_.apk I changed the package name so you can install it alongside the upstream app |
|
@MaeIsBad You're awesome you know that? |
|
i'll take a look today after work and try to get it merged soon, thanks for the testing guys |
|
Hey! Just a quick thing I noticed today. While it works great for PostNL shipments send towards The Netherlands (regardless of origin), it doesn't do well on international PostNL shipments send towards anywhere outside of The Netherlands. Those are most common for returns (some stores have German warehouses) but can happen for any reason people ship abroad. It's not too big of a deal (or at least not something you want to skip merging this for) as most people using PostNL will have most their parcels send towards a Dutch address, but might be something you document somewhere. |
i think we can open a separate tracking issue for this after merging. i'll review it asap |
|
Yeah I left a TODO comment about that. Currently parcel only supports providing a postcode and I wanted to keep this PR minimal while still implementing the most common use case. I could add some sort of hack that lets you specify country by appending a country code at the end of your postcode but I think it's best to keep this to a minimum |
|
@itsvic-dev take your time with this, thanks for your work as maintainer 🙏 |
itsvic-dev
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm

Had some time sick in bed and waiting for a delivery, so I implemented this.
Could probably use some additional work once I'm more clear headed + I'm not familiar with kotlin/android dev but it's good enough to be useful for me.
Closes #101