Invoke ih264d_free_dynamic_bufs() in ih264d_allocate_dynamic_bufs() - #142
Merged
Merged
Conversation
harishdm
marked this pull request as draft
July 10, 2026 17:11
In order do this, moved freeing of dynamic bitstream buffer outside free_dynamic_bufs() call. This allocation is not done inside allocate_dynamic_bufs() and hence shouldn't be freed in free_dynamic_bufs(). This will ensure that any memory that is allocated before and not yet freed, will be freed. This is done as a precaution to ensure there are no leaks.
harishdm
marked this pull request as ready for review
July 10, 2026 18:38
Collaborator
|
LGTM |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This will ensure that any memory that is allocated before and not yet freed, will be freed. This is done as a precaution to ensure there are no leaks.