fix(core): keep release verification green on current Clippy#35
Draft
hefxpzwk wants to merge 1 commit into
Draft
fix(core): keep release verification green on current Clippy#35hefxpzwk wants to merge 1 commit into
hefxpzwk wants to merge 1 commit into
Conversation
Use Clippy's byte string form for quote detection without changing string/comment masking behavior. Constraint: Release workflow runs cargo clippy --workspace --all-targets -- -D warnings on the current GitHub runner toolchain. Rejected: Suppressing clippy::byte_char_slices | The expression has an equivalent clearer byte-string form. Confidence: high Scope-risk: narrow Directive: Keep quote detection behavior unchanged; this only satisfies the lint form. Tested: ./scripts/verify.sh; git diff --check Not-tested: GitHub release dry-run after merge to develop is still pending.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Scope
byte_char_sliceswarning in quote detection.Validation
./scripts/verify.shpassed locally.git diff --checkpassed locally.Release impact
v0.1.1-beta.0fromdevelop, because the release workflow'sVerify source refjob runs Clippy with-D warnings.Risk notes
crates/tfy-core/src/code.rs.