-
Notifications
You must be signed in to change notification settings - Fork 3
Zh/proxmox client api token authentication #62
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Draft
zkhussain
wants to merge
4
commits into
dev
Choose a base branch
from
zh/proxmox-client-api-token-auth
base: dev
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Draft
Changes from all commits
Commits
Show all changes
4 commits
Select commit
Hold shift + click to select a range
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,28 @@ | ||
| using System; | ||
| using System.Threading.Tasks; | ||
| using CSLabs.Api.Models; | ||
| using CSLabs.Api.Services; | ||
| using FluentScheduler; | ||
| using Microsoft.Extensions.DependencyInjection; | ||
|
|
||
| namespace CSLabs.Api.Jobs | ||
| { | ||
| public class ApiTokenJob : AsyncJob | ||
| { | ||
| private readonly IServiceProvider _serviceProvider; | ||
|
|
||
| public ApiTokenJob(IServiceProvider provider) | ||
| { | ||
| _serviceProvider = provider; | ||
| } | ||
|
|
||
| protected override async Task ExecuteAsync() | ||
| { | ||
| using var scope = _serviceProvider.CreateScope(); | ||
| var context = scope.ServiceProvider.GetService<DefaultContext>(); | ||
| var service = scope.ServiceProvider.GetService<ProxmoxApiTokenService>(); | ||
|
|
||
| await service.ManageApiToken(context); | ||
| } | ||
| } | ||
| } |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,16 @@ | ||
| namespace CSLabs.Api.Proxmox.Responses | ||
| { | ||
| public class ApiTokenResponse | ||
| { | ||
| public string Value { get; set; } | ||
| public TokenInfo Info { get; set; } | ||
| public string FullTokenId { get; set; } | ||
| } | ||
|
|
||
| public class TokenInfo | ||
| { | ||
| public string Comment { get; set; } | ||
| public int Expire { get; set; } | ||
| public bool PrivSep { get; set; } | ||
| } | ||
| } |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,27 @@ | ||
| using System; | ||
| using System.Linq; | ||
| using System.Threading.Tasks; | ||
| using CSLabs.Api.Models; | ||
| using CSLabs.Api.Proxmox; | ||
| using Microsoft.EntityFrameworkCore; | ||
|
|
||
| namespace CSLabs.Api.Services | ||
| { | ||
| public class ProxmoxApiTokenService | ||
| { | ||
| public ProxmoxManager ProxmoxManager { get;} | ||
|
|
||
| public ProxmoxApiTokenService(ProxmoxManager manager) | ||
| { | ||
| ProxmoxManager = manager; | ||
| } | ||
|
|
||
| public async Task ManageApiToken(DefaultContext context) | ||
| { | ||
| var hypervisor = await context.Hypervisors.FirstOrDefaultAsync(); | ||
| var primaryHypervisorNode = await ProxmoxManager.GetPrimaryHypervisorNode(hypervisor); | ||
| var api = ProxmoxManager.GetProxmoxApi(primaryHypervisorNode); | ||
| await api.ManageApiToken(); | ||
| } | ||
| } | ||
| } |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@jasekiw Using API tokens gets rid of the need to log in to the proxmox API with username and password. The Login method we use logs in and generates a ticket, which is used to authenticate noVNC in cslabs-webapp/src/api/rfb.ts. Since API tokens will remove the need for log in, a ticket will not be generated to authenticate to noVNC, and I am receiving a 401 unauthorized if I do so. Reference to the proxmox API here. I may have missed something, I am not sure what we can do or maybe there is another way?
Uh oh!
There was an error while loading. Please reload this page.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@zkhussain Is there a time you are available to go through this via zoom? I would like you to demonstrate the issue for me if you can.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes, evening times work best. Tomorrow after the meeting?