Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
17 changes: 17 additions & 0 deletions evaluation/pdf-table-extraction.md
Original file line number Diff line number Diff line change
@@ -0,0 +1,17 @@
# 独立した表のセル探索と抽出エラー診断(2026-10-08)

基準は `bfdd545`(v0.7.8)。[対象PDF](https://www.release.tdnet.info/inbs/140120261008547647.pdf) は26ページ、SHA-256は `ed8e4105ee93a8fb44c294f5be9f88cce9adb1e8e2500d977be3c0a02d726ecf`。旧版では表紙の文字・描画演算は読めるが、独立した表の軸の組合せが増え、`SOURCE_DRAWING:表のセル解析の処理上限` で停止した。旧調査の `validatePages` 成功は抽出できた25ページだけで、PDF全体の成功ではなかった。

### 変更と担当テスト

- `table-layout` は既存の最小幅8・高さ4と連続する上辺・左辺を必要条件として探索を絞る。軸ごとの実罫線を再利用し、辺が途切れた後の遠い軸も探索しない。実罫線・許容幅・最小閉矩形の順序は不変。罫線2,000本と候補100,000回の上限を維持し、枝刈りの開始点・左辺探索にも各100,000回の上限を置く。既に旧上限内だった入力では、各追加カウントは旧候補数以下になる。
- `table-layout.test.ts` は独立6表、結合セル、最小寸法、分割線の許容幅、欠けた各辺、密なセルと疎なページの上限を担当する。企業・PDFごとの例外や文字だけへの代替は加えない。
- `offscreen/index.test.ts` は一部成功後のページ読込・文字・演算・レイアウト失敗、後始末による元例外の上書き防止、文書読込失敗を確認する。`background/index.test.ts` はJSON通信後のページ・段階・例外名・コード・元メッセージを `pdfExtractionError` に保存し、LLMを呼ばず停止することと接頭辞の重複防止を担当する。
- `useSummarize.test.ts` は診断コピー中の拡張無効化を同期例外・非同期拒否で確認する。TDnetページの再読み込みを案内し、コピー済みと表示しない。

### 検証結果と境界

- 最終製品コードで `npm test` は1,274件/41ファイル成功。type-check・lint・build、同梱CMap168個とLICENSEのバイト照合も成功。
- 対象PDFをPDF.js 5.4.394と本番共通 `extractPdfPageLayout` で全26ページ抽出後に `validatePages` を実行した。失敗・空ページ0、24,207文字。表紙106セルの座標・順序は上限だけを外した旧探索結果と一致し、従来成功していた残り25ページの全抽出データも基準と一致。全ページの生成入力SHA-256は `970d76f4b74507f278cfd615bce6569ffe6cfac9c13a189667e3e957645d5496`。
- 保存済みの `reporting-table-corpus`・`pdf-layout-corpus`・`ir-semantic-corpus` 合計20エントリ/32ページで、抽出データと生成入力が基準と完全一致。実PDF20件を再取得した検証ではない。独立差分レビューでは、疎な罫線・結合セル・最小寸法付近のランダム2,500グリッドも旧探索とセル順・ID・座標・原文所属が一致した。
- 固定応答smokeの事前検査は成功・部分成功・最終失敗の3例とも成功。クラウドChromiumでの実拡張画面は起動時の `socket() failed: Operation not permitted` で停止し、実画面・実拡張通信の成功には数えない。実API呼出し0。対象PDFの実モデルによる要約品質と利用者のChrome画面は未検証。
51 changes: 51 additions & 0 deletions src/background/index.test.ts
Original file line number Diff line number Diff line change
Expand Up @@ -10,6 +10,7 @@ import type { ExtractedPage, ExtractionMode } from '../types/summaryMetadata';
import { serializePagesForAnalysis } from '../lib/page-text';
import { fixedOrganization } from '../lib/fixtures/summary-narrative-source';
import type { SummaryAttempt } from '../lib/summary-trace';
import type { PdfExtractionErrorDetails } from '../lib/pdf-extraction-error';

const mocked = vi.hoisted(() => ({
generateText: vi.fn(),
Expand Down Expand Up @@ -288,6 +289,56 @@ describe('要約・採点・追加分析の分離', () => {
}
);

it('Offscreenの元例外を診断JSONへ保持し、失敗ページから生成しない', async () => {
const request = await setup(false);
const details: PdfExtractionErrorDetails = {
pageNumber: 2,
stage: 'page-layout',
name: 'Error',
code: 'SOURCE_DRAWING',
message: 'SOURCE_DRAWING:表のセル解析の処理上限',
};
const response = JSON.parse(
JSON.stringify({
success: false,
error: `PDF抽出エラー: PDF p.2: ${details.message}`,
pdfExtractionError: details,
})
);
vi.mocked(chrome.runtime.sendMessage).mockResolvedValueOnce(response);
const result = await request({ action: 'summarize' });
const writes = vi.mocked(chrome.storage.local.set).mock.calls;
const lastWrite = writes[writes.length - 1][0] as Record<string, unknown>;
const trace = JSON.parse(JSON.stringify(lastWrite.summaryLastRunV1));
expect(result.error).toBe(response.error);
expect(trace).toMatchObject({
runId: result.diagnosticRunId,
outcome: 'failure',
error: response.error,
pdfExtractionError: details,
attempts: [],
usage: [],
resultId: null,
});
expect(matchingSummaryTrace(trace, 'test.pdf', result.diagnosticRunId, null)).toEqual(trace);
expect(mocked.generateText).not.toHaveBeenCalled();
});

it.each([undefined, { pageNumber: 0, stage: 'page-layout', message: 'invalid details' }])(
'旧形式または不正な抽出エラー詳細%sでも元メッセージを失わず接頭辞を重複させない',
async (details) => {
const request = await setup(false);
vi.mocked(chrome.runtime.sendMessage).mockResolvedValueOnce({
success: false,
error: 'PDF抽出エラー: PDF抽出エラー: SOURCE:PDF p.1の抽出失敗',
pdfExtractionError: details,
});
const result = await request({ action: 'summarize' });
expect(result.error).toBe('PDF抽出エラー: SOURCE:PDF p.1の抽出失敗');
expect(mocked.generateText).not.toHaveBeenCalled();
}
);

it.each(['success', 'failure', 'earlyFailure', 'lateExtraction'] as const)(
'古い完了%sは新しい要求の診断を上書きしない',
async (stage) => {
Expand Down
19 changes: 14 additions & 5 deletions src/background/index.ts
Original file line number Diff line number Diff line change
@@ -1,4 +1,10 @@
import { SUMMARY_TRACE_KEY, summaryBuildDigest, type SummaryTrace } from '@/lib/summary-trace';
import {
PdfExtractionError,
pdfExtractionError,
readPdfExtractionError,
type PdfExtractionStage,
} from '@/lib/pdf-extraction-error';
import { serializeCandidateSource } from '@/lib/fact-candidates';
import type { LLMConfig } from '@/lib/llm-client';
import { configuredApiUrl } from '@/lib/llm-endpoint';
Expand Down Expand Up @@ -303,6 +309,7 @@ async function handleSummarize(request: SummarizeRequest, runId: string) {
} catch (error) {
trace.outcome = 'failure';
trace.error = error instanceof Error ? error.message : String(error);
if (error instanceof PdfExtractionError) trace.pdfExtractionError = error.details;
await saveTrace();
throw error;
}
Expand Down Expand Up @@ -540,6 +547,7 @@ async function extractTextFromPDF(
documentType: DocumentType,
extractionMode: ExtractionMode
): Promise<PdfExtractionResult> {
let stage: PdfExtractionStage = 'transport';
try {
// ArrayBufferを配列に変換して送信
const uint8Array = new Uint8Array(pdfData);
Expand All @@ -553,9 +561,13 @@ async function extractTextFromPDF(
});

if (!response.success) {
throw new Error(response.error || 'PDF抽出に失敗しました');
throw (
readPdfExtractionError(response.pdfExtractionError) ??
new Error(response.error || 'PDF抽出に失敗しました')
);
}

stage = 'validation';
validatePages(response.pages);
if (
typeof response.text !== 'string' ||
Expand All @@ -582,9 +594,6 @@ async function extractTextFromPDF(
};
} catch (error) {
console.error('[Background] PDF抽出エラー:', error);
if (error instanceof Error) {
throw new Error(`PDF抽出エラー: ${error.message}`);
}
throw new Error('PDFからテキストを抽出できませんでした。');
throw pdfExtractionError(error, stage);
}
}
7 changes: 6 additions & 1 deletion src/content/SummaryButton.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -167,7 +167,12 @@ const SummaryButton: React.FC<SummaryButtonProps> = ({ rowData, row, iframeDoc }
}
} catch (e) {
if (request !== diagnosticRequest.current) return;
setDiagnosticError(e instanceof Error ? e.message : String(e));
const message = e instanceof Error ? e.message : String(e);
setDiagnosticError(
/extension context invalidated/i.test(message)
? '拡張機能との接続が切れています。TDnetのページを再読み込みしてから、診断JSONのコピーをやり直してください。'
: message
);
}
};
const handleClick = () => {
Expand Down
29 changes: 29 additions & 0 deletions src/content/hooks/useSummarize.test.ts
Original file line number Diff line number Diff line change
Expand Up @@ -779,6 +779,35 @@ describe('実Reactの要約行アクション配置', () => {
expect(writeText).toHaveBeenCalledTimes(3);
});

it.each(['throw', 'reject'] as const)(
'診断読込の無効化エラー(%s)はページ再読み込みを案内し、コピー成功にしない',
async (failure) => {
settings.experimentalScoring = false;
sendMessage.mockResolvedValueOnce(await responseFor());
const writeText = vi.fn().mockResolvedValue(undefined);
vi.stubGlobal('navigator', { clipboard: { writeText } });
const { row, button } = await mountButton();
await click(button);
const summaryRow = await summaryRowFor(row);
const host = summaryRow.querySelector('[data-diagnostic-root]')!;
const error = new Error('Extension context invalidated.');
if (failure === 'throw')
vi.mocked(chrome.storage.local.get).mockImplementationOnce(() => {
throw error;
});
else vi.mocked(chrome.storage.local.get).mockRejectedValueOnce(error);
await click(host.querySelector('button')!);
expect(host.querySelector('[role="alert"]')?.textContent).toBe(
'拡張機能との接続が切れています。TDnetのページを再読み込みしてから、診断JSONのコピーをやり直してください。'
);
expect(host.querySelector('[role="status"]')?.textContent).toBe('');
expect(host.querySelector('textarea')).toBeNull();
expect(writeText).not.toHaveBeenCalled();
expect(sendMessage).toHaveBeenCalledTimes(1);
expect(summaryRow.textContent).toContain('100百万円');
}
);

it('エラー行でも閉じると診断を用意し、エラーの隣の全文再要約で回復する', async () => {
settings.extractionMode = 'smart';
settings.experimentalScoring = false;
Expand Down
94 changes: 94 additions & 0 deletions src/lib/pdf-extraction-error.ts
Original file line number Diff line number Diff line change
@@ -0,0 +1,94 @@
import { record } from './fact-contract';

const stages = [
'document-load',
'page-load',
'text-content',
'operator-list',
'page-layout',
'validation',
'selection',
'cleanup',
'transport',
] as const;
export type PdfExtractionStage = (typeof stages)[number];

/** Plain data only: Error properties do not survive Chrome message serialization. */
export interface PdfExtractionErrorDetails {
pageNumber: number | null;
stage: PdfExtractionStage;
name: string;
code: string | number | null;
message: string;
}

export class PdfExtractionError extends Error {
constructor(readonly details: PdfExtractionErrorDetails) {
const message = details.message.replace(/^(?:PDF抽出エラー:\s*)+/, '');
super(
`PDF抽出エラー: ${details.pageNumber === null ? '' : `PDF p.${details.pageNumber}: `}${message}`
);
this.name = 'PdfExtractionError';
}
}

/** Keep the earliest stage and original cause when a failure crosses another boundary. */
export function pdfExtractionError(
error: unknown,
stage: PdfExtractionStage,
pageNumber: number | null = null
): PdfExtractionError {
if (error instanceof PdfExtractionError) return error;
const source = record(error) ? error : {};
const message = typeof source.message === 'string' ? source.message : String(error);
return new PdfExtractionError({
pageNumber,
stage,
name: typeof source.name === 'string' ? source.name : 'Error',
code:
typeof source.code === 'string' ||
(typeof source.code === 'number' && Number.isFinite(source.code))
? source.code
: (message.match(/^([A-Z][A-Z0-9_]+):/)?.[1] ?? null),
message,
});
}

export async function withPdfExtractionStage<T>(
stage: PdfExtractionStage,
pageNumber: number | null,
operation: () => T | Promise<T>
): Promise<T> {
try {
return await operation();
} catch (error) {
throw pdfExtractionError(error, stage, pageNumber);
}
}

/** Rehydrate only the diagnostic fields; never trust or copy arbitrary error properties. */
export function readPdfExtractionError(value: unknown): PdfExtractionError | null {
if (
!record(value) ||
!(
value.pageNumber === null ||
(Number.isInteger(value.pageNumber) && Number(value.pageNumber) > 0)
) ||
!stages.includes(value.stage as PdfExtractionStage) ||
typeof value.name !== 'string' ||
typeof value.message !== 'string' ||
!(
value.code === null ||
typeof value.code === 'string' ||
(typeof value.code === 'number' && Number.isFinite(value.code))
)
)
return null;
return new PdfExtractionError({
pageNumber: value.pageNumber as number | null,
stage: value.stage as PdfExtractionStage,
name: value.name,
code: value.code as string | number | null,
message: value.message,
});
}
12 changes: 7 additions & 5 deletions src/lib/pdf-layout.ts
Original file line number Diff line number Diff line change
Expand Up @@ -16,6 +16,7 @@ import {
type DrawingOperation,
} from './pdf-drawing';
import { buildTableRegions, buildTableCells } from './table-layout';
import { withPdfExtractionStage } from './pdf-extraction-error';

export interface PdfSpan {
id: string;
Expand All @@ -36,11 +37,12 @@ export async function extractPdfPageLayout(
pageNumber: number,
operatorRegistry: Record<string, number>
): Promise<ExtractedPage> {
const [text, operators] = await Promise.all([page.getTextContent(), page.getOperatorList()]);
return extractPageLayout(
text.items,
pageNumber,
captureDrawingOperations(operators, operatorRegistry)
const [text, operators] = await Promise.all([
withPdfExtractionStage('text-content', pageNumber, () => page.getTextContent()),
withPdfExtractionStage('operator-list', pageNumber, () => page.getOperatorList()),
]);
return withPdfExtractionStage('page-layout', pageNumber, () =>
extractPageLayout(text.items, pageNumber, captureDrawingOperations(operators, operatorRegistry))
);
}

Expand Down
2 changes: 2 additions & 0 deletions src/lib/summary-trace.ts
Original file line number Diff line number Diff line change
Expand Up @@ -3,6 +3,7 @@ import type { Diagnostic } from './fact-candidates';
import type { LLMConfig } from './llm-client';
import { record } from './fact-contract';
import { normalizeTdnetPdfUrl } from './tdnet-url';
import type { PdfExtractionErrorDetails } from './pdf-extraction-error';
export const SUMMARY_TRACE_KEY = 'summaryLastRunV1';
export type Usage = Parameters<NonNullable<LLMConfig['onUsage']>>[0];
export interface SummaryAttempt {
Expand Down Expand Up @@ -34,6 +35,7 @@ export interface SummaryTrace {
elapsedMs: number;
outcome: 'running' | 'firstSuccess' | 'repairSuccess' | 'partialSuccess' | 'failure';
error: string | null;
pdfExtractionError?: PdfExtractionErrorDetails;
}
/** A fresh attempt must match its run; cached success must match its exact result. */
export function matchingSummaryTrace(
Expand Down
Loading
Loading