Repository navigation
リリース検証で設定読込前に進むテストの待機条件を修正 - #36
Merged
Merged
Conversation
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
原因
Release #31 は、ビルド前の
npm testで診断保存の試験が1件失敗していました。マウント用helperが、過去の
chrome.storage.local.get呼出しだけで準備完了と判定していました。診断保存時の読込が残っていると、設定の非同期ハッシュ計算前にボタンをクリックし、設定未読込のエラー行が表示されてキャッシュが保存されません。修正
検証
npm ci、ローカルで0.7.13へ一時更新した条件で確認npm run type-check、npm run lint、npm test(1,636件/58ファイル)、npm run buildが成功リリース再開時の注意
旧runのcheckout先はPR #35のmerge commitに固定されているため、再実行してもこの修正は入りません。修正を取り込んだ新しいmerge commitのRelease workflowで検証する必要があります。
このPRにはリリースラベルを付けていません。ローカル検証の成功と、GitHub Actions上のリリース成功は分けて確認します。