Repository navigation
前年比較・要約保存・追加分析の全体要約を改善 - #37
Conversation
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 3b64effe5e
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| } catch { | ||
| } catch (error) { | ||
| if (run === runRef.current) { | ||
| setHasCached(false); |
There was a problem hiding this comment.
Preserve the previous cache after a replacement write fails
When a cached summary is opened and the user selects 「再要約」, the existing entry remains in chrome.storage.local if the replacement set() fails (for example because the quota is full), but this line unconditionally marks it unavailable. Closing the displayed result therefore changes the button to 「要約」, and the next click makes another paid LLM request instead of reopening the still-valid older cache; this can repeat indefinitely while storage remains full. Retain or re-check the prior cache state on a failed replacement write.
Useful? React with 👍 / 👎.
There was a problem hiding this comment.
a84ac8a で対応しました。
原因は、新しい結果の保存失敗を「使える保存結果がない」と扱っていたことでした。同じキーの既存キャッシュを、展開・原文・表示・結果IDまで再検証して再表示可能性を維持します。画面に出ている新しい結果は置き換えず、閉じて再度「表示」したときに保存済みの結果を開きます。
同じ傾向の経路も見直しました。
- 一時的な読込失敗や古くなった読込を「保存なし」と扱わない
- 「表示」を押した時点で保存が消えていても、その操作から有料生成へ進めない
- 「要約」でも毎回保存を確認し、現在のキーで正常に「保存なし」と確認できた場合だけ生成する
- 設定変更・削除・置換後に返った遅い保存再確認を反映しない
旧形式・圧縮形式の上書き失敗→閉じる→再表示、初回の存在確認失敗、設定/削除/置換との競合、表示中の新しい実行を旧結果で置き換えないことを追加検証しました。全1,680テスト、型チェック、lint、ビルド、固定応答の事前検証が成功しています。提供された応答の再現要約も変更前と一致し、実モデルAPIは呼んでいません。
|
Codex Review: Didn't find any major issues. Nice work! Reviewed commit: ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
If Codex has suggestions, it will comment; otherwise it will react with 👍. Codex can also answer questions or update the PR. Try commenting "@codex address that feedback". |
変更内容
分析指紋をv124へ更新しています。拡張機能のバージョン変更・リリースは含みません。
検証
未確認・制約