fix: relax length comparison lint to skip non-empty checks

crates/passes/src/passes/lints/ast_walk/checks/manual_is_empty.rs

@@ -39,21 +39,15 @@ pub fn check_manual_is_empty(expression: &Expression, ctx: &NodeCtx) {
         return;
     }
 
-    let negate = match operator {
-        Equal | LessThanOrEqual => false,
-        NotEqual | GreaterThan => true,
-        _ => return,
-    };
+    if !matches!(operator, Equal | LessThanOrEqual) {
+        return;
+    }
 
     let Some(receiver_text) = receiver.as_dotted_path() else {
         return;
     };
 
-    let replacement = if negate {
-        format!("!{receiver_text}.is_empty()")
-    } else {
-        format!("{receiver_text}.is_empty()")
-    };
+    let replacement = format!("{receiver_text}.is_empty()");
 
     ctx.sink
         .push(diagnostics::lint::manual_is_empty(span, &replacement));

tests/ui/lint/mod.rs

@@ -844,8 +844,8 @@ fn main() {
 }
 
 #[test]
-fn manual_is_empty_not_equals_zero() {
-    assert_lint_snapshot!(
+fn manual_is_empty_not_equals_zero_no_warning() {
+    assert_no_lint_warnings!(
         r#"
 fn main() {
   let xs = [1, 2, 3]
@@ -856,8 +856,8 @@ fn main() {
 }
 
 #[test]
-fn manual_is_empty_greater_than_zero() {
-    assert_lint_snapshot!(
+fn manual_is_empty_greater_than_zero_no_warning() {
+    assert_no_lint_warnings!(
         r#"
 fn main() {
   let xs = [1, 2, 3]
@@ -931,6 +931,30 @@ fn main() {
     );
 }
 
+#[test]
+fn manual_is_empty_zero_less_than_no_warning() {
+    assert_no_lint_warnings!(
+        r#"
+fn main() {
+  let xs = [1, 2, 3]
+  let _ = 0 < xs.length()
+}
+"#
+    );
+}
+
+#[test]
+fn manual_is_empty_zero_not_equals_no_warning() {
+    assert_no_lint_warnings!(
+        r#"
+fn main() {
+  let xs = [1, 2, 3]
+  let _ = 0 != xs.length()
+}
+"#
+    );
+}
+
 #[test]
 fn manual_is_empty_compare_one_no_warning() {
     assert_no_lint_warnings!(