Migrating world from "Vault Hunters Third Edition - Remastered" looses some stats

[albin-engstrom]

Migrating largely works well, minor but understandable issues are that mod unlocks that no longer exist are lost.
And items from mods that no longer exist are lost.
But that is perfectly understandable and I can easily remedy by giving myself knowledge stars and suitable items to compensate.

However, something I have not managed to fix is that some stats are lost.

One are the in-vault stats, which only migrates crystals crafted but nothing else;

Another is general vault history being empty;

Perhaps more things will appear as I play, I'm still evaluating if I want to migrate, start over with the new pack, or don't switch packs at all.
But it seems promising, and I'll likely migrate either way, but while stats are not that important I know that them being wrong will itch at the back of my mind as I play.

I was using Update 2 (2.0.4) of VH3 Remastered and now 0.33.2hf of this pack.

[iwolfking]

It's really a vanilla Vault Hunters issue that causes this. Vault History is insanely fragile and adding new objectives causes all pre-existing history to break and going from vanilla to Wold's is definitely going to add some things 😆.

It's good to have an issue open about migrating though, people do it fairly often but don't talk too much about issues they may run into (it should generally work fine for the most part though).

[albin-engstrom]

Understandable, that it even works largely fine to migrate was a surprise.
I found some old discussions about it where people mentioned some issues with migrating. but without seeing that I don't know if I'd even think to try.
So this might indeed encourage some people to try migrating as well.

While the detailed history of vault runs might be too hard to handle, I wonder if the specific stats might be manageable manually at least.
I would think that simply inputting my "Total Vaults" and such somewhere would be doable, but I have not figured out how.

[iwolfking]

These stats are pulled/generated from said Vault Snapshot files actually, but the Crystals Crafted comes from another data file which is why that one still loads fine.

[albin-engstrom]

Ah, okay. That makes sense.

[albin-engstrom]

There also seems to be issues with world generation, likely at the points where generation done by the old pack ended and the new one begins. I did see someone mention that in an old discussion.

And now I've found some places where biomes and general terrain shift at a hard cutoff at the chunk edge.
Most notable when a mountain is simply cut on half.

Clearly seen on the map in this area.

Both packs use the same version of Regions Unexplored, so I would not expect that to be the issue.

I did note that things from the mod Cloud Storage where near one such cutoff point. But I don't think that was the case for all places.

I note that Tectonic seem to be a new mod in this pack that also effect world gen, perhaps that is the cause.

[iwolfking]

VH3 Remastered is missing both Terralith and Tectonic that Wold's uses is why this happens, yeah.

[iwolfking]

Well actually, I think just Terralith? I think I recall them adding Tectonic in Remastered.

Normal VH3 has Terralith but not Tectonic or Regions Unexplored.

[albin-engstrom]

Yeah, that seems to be correct. Remastered has Tectonic and Regions Unexplored but not Terralith.

So in theory one might be able to solve this by removing Terralith before loading the migrated world, unless that breaks something else.
Loosing its features of course, but perhaps worth the trade-off for some.

[iwolfking]

It's perfectly fine to remove Terralith from the pack, it used to cause KubeJS errors (which are harmless) but the script checks if the mod is installed now before trying to load anything related to it.

[albin-engstrom]

As the issue is not important enough to roll back to my pre-migration world I tested deleting the odd new world gen using mcaselector, then removing "Terralith Loader" and then visit the same places again. Smilar issues still remain with the world gen then. So Terralith is seemingly not the sole reason for this.

Although removing Terralith does seem to make the border generally better from a top down perspective.
Meaning mountains, oceans, etc. continue roughly as expected instead of being as abruptly cut off for something entirely different.
But elevations, and the actual biome, still have the same hard cutoff.

So it looks better on the map, but on actual visits still look quite odd.

[albin-engstrom]

As previously stated the version for Regions Unexplored is the same.
But I now saw that the version of Tectonic is wildly different.

VH3 Remastered currently uses 2.3.5a.
Wolds uses 1.1.10a.

That perhaps contributes to these issues, is there a reason for using such and old release of Tectonic?

[iwolfking]

It would require me to be aware there was an update. :P

1.18.2 was a dated MC version when I started on this 2 and a half years ago, the version is from around then, don't necessarily expect a lot of updates to mods.

It does sound like it'd cause similar issues to existing Wold's worlds to update, I'd have to look into it.

[albin-engstrom]

Ah, okay. Understandable.

I can report that updating Tectonic to 2.3.5a. significantly improved the world-gen clash.

The best results I've had so far is by only doing that, also (or only) removing Terralith yields worse results.

Updating Tectonic makes it so elevation nearly always matches, as does the general biome type (Ocean, mountain, forest, etc.)

[albin-engstrom]

I can actually report that it (meaning only update Tectonic to match VH3 Remastered) worked perfectly, as far as I've seen.
Unclear why it didn't seem to the first time.

My guess is that during testing I deleted large areas which created long straight borders between old and new world gen.
When I decided to make the final actual pass of fixing things in the world I was intending to continue using I carefully just deleted the "wrong" chunks. And where there were straight borders I feathered the edges to make them uneven.
That perhaps helped the old and new world gen to blend.

Either way, updating Tectonic seems to have completely solved the world gen issues.

[iwolfking]

I will update Tectonic next update. As far as existing worlds goes, seems there is a setting that will let you upgrade to v2+ versions of the mod without issues, so should be fine.