Skip to content

fix(dl): avoid export JSON parse race#1244

Open
expary wants to merge 1 commit into
iyear:masterfrom
expary:expary/fix-dl-file-parse-race
Open

fix(dl): avoid export JSON parse race#1244
expary wants to merge 1 commit into
iyear:masterfrom
expary:expary/fix-dl-file-parse-race

Conversation

@expary

@expary expary commented May 31, 2026

Copy link
Copy Markdown

Summary

  • read Telegram export chat metadata with a synchronous JSON decoder
  • parse message entries from a separate file handle to avoid shared offset races
  • add regression coverage for repeated parsing of a 5000-message export

Tests

  • go test ./pkg/tmessage -count=50
  • go test $(go list ./... | grep -v '^github.com/iyear/tdl/test$') ./core/... ./extension/...

Closes #1242

Read chat metadata and message entries from independent file handles so jstream's streaming decoder cannot race on shared file offsets.

Closes iyear#1242
@expary expary requested a review from XMLHexagram as a code owner May 31, 2026 22:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Bug] tdl dl -f 的时候,本地的同一份json文件,多次执行会读丢数据吗.

1 participant