Skip to content

Add ssl_options to make_request, so that client TLS certificate could be set.#4

Open
smira wants to merge 1 commit into
izrik:masterfrom
smira:client-ssl-certs
Open

Add ssl_options to make_request, so that client TLS certificate could be set.#4
smira wants to merge 1 commit into
izrik:masterfrom
smira:client-ssl-certs

Conversation

@smira
Copy link
Copy Markdown
Contributor

@smira smira commented Jul 10, 2015

Also fix some minor bugs.

@smira
Copy link
Copy Markdown
Contributor Author

smira commented Jul 10, 2015

With this patch, we can pass SSL options used when making request:

self.deproxy.make_request(..., ssl_options={'keyfile': '...key', 'certfile': '...crt'})

@izrik
Copy link
Copy Markdown
Owner

izrik commented Jul 28, 2015

@smira I've added you to this project as a collaborator, since you seem committed to the project. =) Feel free to merge PR's as you see fit. Did you still need me to do code review?

@smira
Copy link
Copy Markdown
Contributor Author

smira commented Jul 29, 2015

@izrik thanks for adding me as a collaborator. I'm posting PRs so that I can track all the changes. I should probably add some tests to each of the PRs and merge them afterwards.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants