Repository navigation
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
{offer:name}or{offer:uuid}Reproduction and verification
Configure a campaign fallback as
{offer:Reserve}and either leave the campaign without a matching flow or disable its last target offer. The visitor reaches Reserve, but the click is logged withoffer_id = NULL. A postback using Reserve's valid token is then rejected with HTTP 409,token/click offer mismatch.The fix records the resolved active offer before logging redirect-style fallback clicks. The existing postback token checks remain unchanged. No migration or new dependency is required.
With the regression tests added and the runtime unchanged, 11 cases fail: ten missing offer attributions and one postback returning 409 instead of 200. With the fix:
git diff --check: passedVerification used an isolated local fixture database; no public deployment was contacted.